Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22707 )
Change subject: [map-utils] micro-optimisation on FindWithDefault invocations ...................................................................... [map-utils] micro-optimisation on FindWithDefault invocations This patch updates the call sites of FindWithDefault() to avoid needless memory allocation and string copying on every call. I also took the liberty of improving the readability of the code in TabletServerPathHandlers::HandleTransactionsPage(). This changelist doesn't contain any functional modifications. Change-Id: Ied846a0f796809e5837b742933900ba4930e918a Reviewed-on: http://gerrit.cloudera.org:8080/22707 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Zoltan Chovan <[email protected]> Reviewed-by: Marton Greber <[email protected]> --- M src/kudu/hms/hms_client.cc M src/kudu/master/hms_notification_log_listener.cc M src/kudu/master/master_service.cc M src/kudu/master/ts_manager.cc M src/kudu/server/default_path_handlers.cc M src/kudu/server/pprof_path_handlers.cc M src/kudu/tools/tool_action_hms.cc M src/kudu/tserver/tserver_path_handlers.cc 8 files changed, 56 insertions(+), 46 deletions(-) Approvals: Alexey Serbin: Verified Zoltan Chovan: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ied846a0f796809e5837b742933900ba4930e918a Gerrit-Change-Number: 22707 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]>
