Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies ...................................................................... Patch Set 24: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22374/24/java/gradle/shadow.gradle File java/gradle/shadow.gradle: http://gerrit.cloudera.org:8080/#/c/22374/24/java/gradle/shadow.gradle@55 PS24, Line 55: Current gradle version doesn't support anything above JDK19 nit: that's not exactly 'current Gradle version', but rather Gradle version used to compile Java components of the Kudu project :) Also, do you think it makes sense to put the exact version number of Gradle here? Also, maybe it's worth it adding a reference to the Gradle's compatibility matrix for posterity -- that should help to update this later on, if needed. https://docs.gradle.org/current/userguide/compatibility.html#java_runtime http://gerrit.cloudera.org:8080/#/c/22374/24/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: PS24: nit: is it possible to revert this back to the original version since there wasn't any actual updates in this file? It's easy to do so by reverting the patch just for this file by `patch -p1 -R < only_build_gradle.diff ` -- To view, visit http://gerrit.cloudera.org:8080/22374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d Gerrit-Change-Number: 22374 Gerrit-PatchSet: 24 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 04 Apr 2025 04:06:55 +0000 Gerrit-HasComments: Yes
