Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22713 )
Change subject: Gcovr support with coverage post-processing ...................................................................... Patch Set 2: (4 comments) overall looks OK to me, just a few nits http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/jenkins/build-and-test.sh@549 PS2, Line 549: .*benchmarks.* Here and below: is this about excluding everything under a directory (i.e. 'src/kudu/benchmarks' for this line)? If so, maybe be more specific by adding path separators into the pattern. http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/jenkins/build-and-test.sh@561 PS2, Line 561: virtualenv -p python3 $BUILD_ROOT/py_env Should the code below run only if gcovr invocation above succeeded? http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/jenkins/build-and-test.sh@566 PS2, Line 566: Gcovr nit: gcovr Since that's the name of the binary, I guess? http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/process_gcovr_report.py File build-support/process_gcovr_report.py: http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/process_gcovr_report.py@45 PS2, Line 45: Here and below: looking at scripts in src/kudu/scripts and other *.py files under build-support, it seems the project uses ts=2 (not ts=4) for Python source code as well. Please make this script using the same convention. -- To view, visit http://gerrit.cloudera.org:8080/22713 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d08cbb03234ec97cda985a35ac1b10a5d28ca20 Gerrit-Change-Number: 22713 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 31 Mar 2025 17:01:06 +0000 Gerrit-HasComments: Yes
