Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22741 )
Change subject: [cmake] add -Werror=unused-result flag ...................................................................... Patch Set 4: > Change has been successfully cherry-picked as > ef7483f784911bcfdefba3c1a0068e26f6c3dbcb > by Yifan Zhang Thank you for review, Yifan! This patch was a part of stacked patches, and now the build is broken once you pushed this one before https://gerrit.cloudera.org/#/c/22740/ that came first in the stack. To fix the build, it's necessary to push https://gerrit.cloudera.org/#/c/22740/ as well. Could you take a look at that patch and provide your feedback, hopefully adding +2, if possible :) It would be great if you have a chance to do so and push https://gerrit.cloudera.org/#/c/22740/ as well sooner than later, because now the build is broken. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/22741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5dd2df4784ba70162ecc0212b3791a5d9a13e5e Gerrit-Change-Number: 22741 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 07 Apr 2025 08:19:41 +0000 Gerrit-HasComments: No
