Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22752 )
Change subject: [consensus] fix result status handling ...................................................................... [consensus] fix result status handling This patch addresses sloppy result handling of functions/methods that return Status under the src/kudu/consensus directory. In addition, this patch introduces a new unsafe runtime flag --raft_allow_committed_pending_index_gap that's now used by the TsRecoveryITestDeathTest.RecoverFromOpIdOverflow test scenario only. The test scenario was reliant on the sloppy result status handling of the call to PendingRounds::SetInitialCommittedOpId() in RaftConsensus::Start() that's been addressed in this patch. It's the path of least resistance compared with updating test scaffolding and the test scenario itself, but it also has a benefit of providing a flag to enable the former result status handling approach in RaftConsensus::Start() when setting last committed OpId for a tablet's Raft consensus implementation. Frankly, I don't think anybody will ever need to re-enable the original bogus behavior of ignoring non-OK result status, but it doesn't hurt to have such an option just in case if I'm missing something here. Change-Id: I6db113c58c6b453bf3cd290ee0dfdd184b63b999 Reviewed-on: http://gerrit.cloudera.org:8080/22646 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> (cherry picked from commit bde9cbad115deb1cd689eb583a1c7a8d3440b156) Reviewed-on: http://gerrit.cloudera.org:8080/22752 --- M src/kudu/consensus/consensus_peers-test.cc M src/kudu/consensus/consensus_peers.cc M src/kudu/consensus/consensus_queue-test.cc M src/kudu/consensus/consensus_queue.cc M src/kudu/consensus/consensus_queue.h M src/kudu/consensus/log-test.cc M src/kudu/consensus/log.cc M src/kudu/consensus/log_anchor_registry.cc M src/kudu/consensus/log_anchor_registry.h M src/kudu/consensus/log_cache-test.cc M src/kudu/consensus/peer_manager.cc M src/kudu/consensus/pending_rounds.cc M src/kudu/consensus/raft_consensus.cc M src/kudu/consensus/raft_consensus_quorum-test.cc M src/kudu/consensus/time_manager-test.cc M src/kudu/integration-tests/ts_recovery-itest.cc 16 files changed, 94 insertions(+), 71 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/22752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.18.x Gerrit-MessageType: merged Gerrit-Change-Id: I6db113c58c6b453bf3cd290ee0dfdd184b63b999 Gerrit-Change-Number: 22752 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
