Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22740 )
Change subject: [tools] fix result status handling ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22740/3/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/22740/3/src/kudu/tools/ksck_remote.cc@709 PS3, Line 709: result_status > nit: Maybe 'return Status::OK();' is more readable? According to the code at lines 703-708, at this point 'result_status' might be non-OK, so it's necessary to return it here. http://gerrit.cloudera.org:8080/#/c/22740/3/src/kudu/tools/tool_action_fs.cc File src/kudu/tools/tool_action_fs.cc: http://gerrit.cloudera.org:8080/#/c/22740/3/src/kudu/tools/tool_action_fs.cc@540 PS3, Line 540: if (const auto s = env->UnlockFile(file_lock); !s.ok()) { : LOG(WARNING) << Substitute("could not unlock file $0: $1", : kLockFilePath, s.ToString()); : } > nit: Could we use the macro WARN_NOT_OK? Done -- To view, visit http://gerrit.cloudera.org:8080/22740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d03b9b806d48a071777b63d497f049675d36a8f Gerrit-Change-Number: 22740 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 07 Apr 2025 17:00:38 +0000 Gerrit-HasComments: Yes
