Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22013 )

Change subject: [docs] Update Kudu 1.18.0 release notes
......................................................................


Patch Set 7:

(22 comments)

http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@73
PS7, Line 73: * Widened the list of HTTP methods in detecting an HTTP client 
connecting to Kudu server’s
            :   RPC port.
I'd think we might omit details like this since this doesn't have a lot of 
user-exposes behavioral changes.  What do you think?


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@75
PS7, Line 75: Added a new metric to track per-RPC timeouts. This helps in 
identifying if requests to a
            :   particular RPC method timed out while being processed.
Does it make sense to add a link to KUDU-3514 here?


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@89
PS7, Line 89: commit
changelist 35716499d


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@92
PS7, Line 92: commit
changelist 3bdaf50b5


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@104
PS7, Line 104: * Previously absent min/max keys in rowset metadata are now 
populated during tablet server bootstrap
             :   after switching --rowset_metadata_store_keys to 'true'.
Consider removing this since it doesn't have a lot of user-related exposure.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@133
PS7, Line 133: * Kudu C++ client now allows setting rpc_max_message_size
             :   (see 
https://issues.apache.org/jira/browse/KUDU-3595[KUDU-3595]).
Is this a duplicate of the item above?


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@135
PS7, Line 135: Prometheus metrics are now available at tablet level. Previously 
they were only available at
             :   server level
Tablet-level metrics are now available in Prometheus format as well. 
Previously, only server-level Kudu metrics were available in Prometheus format.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@137
PS7, Line 137: KUDU-3633[KUDU-3563])
typo: the link and the tag don't match.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@138
PS7, Line 138: for multiple tables
... for multiple tables and against the whole Kudu cluster.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@139
PS7, Line 139: Upgraded several C++ and Java 3rd-party dependencies:
Do we really need this full list in here?  Especially with several of them 
being test-only dependencies.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@191
PS7, Line 191: The example Kudu C++ client application now works with 
HMS-enabled Kudu clusters.
Move this into the 'Optimizations and improvements' section.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@222
PS7, Line 222: huge response payloads
response payloads up to 2GByte in size


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@240
PS7, Line 240: * Fixed the Ranger client log count limit not working.
Remove this since this is a test-only fix.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@241
PS7, Line 241: * Fixed a bug when a new master with empty local directories 
tries to connect to an existing cluster
             :   (see 
https://issues.apache.org/jira/browse/KUDU-3437[KUDU-3437]).
Remove this since this is a test-only fix.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@244
PS7, Line 244: * Fixed a bug in multi-master cluster when MiniDumps enabled
             :   (see 
https://issues.apache.org/jira/browse/KUDU-3491[KUDU-3491]).
Remove this since this is a test-only fix.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@261
PS7, Line 261: * Fixed the issue where trailing null/zero bytes were truncated
             :   (see 
https://issues.apache.org/jira/browse/KUDU-3646[KUDU-3646]).
Instead, remove this and add an entry on KUDU-3648:

* Fixed zlib-related errors when processing HMS notification events (see 
https://issues.apache.org/jira/browse/KUDU-3648[KUDU-3648]).


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@263
PS7, Line 263: Fixed the issue where retrying close() syscall on EINTR is 
addressed
close() isn't retried on EINTR anymore


Alternatively, remove this since it doesn't have a lot of user-related exposure.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@270
PS7, Line 270: * Fixed unnecessary dependencies introduced in KUDU-3551
             :   (see 
https://issues.apache.org/jira/browse/KUDU-3610[KUDU-3610]).
Remove this since KUDU-3551 functionality isn't present in any of the previous 
releases.


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@272
PS7, Line 272: * Fixed heap-use-after-free issue in Op-driver
             :   (see 
https://issues.apache.org/jira/browse/KUDU-3620[KUDU-3620]).
This seems to be a duplicate of the entry at line 256


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@302
PS7, Line 302: Applications
             :   written against Kudu 1.17 will compile and run against the 
Kudu 1.18 client library and
             :   vice-versa.
Just to double-check: is this still so after upgrading Gradle to 7.6.4 version 
and introducing new run-time dependencies as a side-effect?

Maybe, since we know the list of dependencies and their types in the POM file 
has been changed, we at least need to add a notice on updating run-time and/or 
compile classpaths?


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@312
PS7, Line 312: Applications
             :   written against Kudu 1.17 will continue to run against the 
Kudu 1.18 client
             :   and vice-versa.
Just to double-check: is this still so even after removing support for Python 
3.0 through 3.5?


http://gerrit.cloudera.org:8080/#/c/22013/7/docs/release_notes.adoc@325
PS7, Line 325: Kudu 1.18.0 includes contributions from 26 people, including 3 
first-time contributors:
It seems there is at least one more contributor to add into the list:
  0xderek <[email protected]> (see 1f89113a618a84d2610410600c012c6180332adc in 
the main and 1a2e7ab3011fcb376703d453b32ad6bae8eee873 in branch-1.18.x)



--
To view, visit http://gerrit.cloudera.org:8080/22013
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.18.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I57642af58d86de0d8f8bc26d06c4607fac6ea321
Gerrit-Change-Number: 22013
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Song Jiacheng <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Fri, 18 Apr 2025 17:16:40 +0000
Gerrit-HasComments: Yes

Reply via email to