Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22744 )
Change subject: KUDU-3608 REST API Follow-up ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/22744/5/src/kudu/master/rest_catalog_path_handlers.cc File src/kudu/master/rest_catalog_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/22744/5/src/kudu/master/rest_catalog_path_handlers.cc@87 PS5, Line 87: return true; > It seems this translation assumes the 'status' passed by callers must be no Done http://gerrit.cloudera.org:8080/#/c/22744/5/src/kudu/master/rest_catalog_path_handlers.cc@89 PS5, Line 89: > This might be a theme on its own (so, maybe consider addressing it in a sep This makes sense, I agree. I removed this block from here and will make a separate changelist along with adding 403 Forbidden to the web server. http://gerrit.cloudera.org:8080/#/c/22744/5/src/kudu/master/rest_catalog_path_handlers.cc@127 PS5, Line 127: : if (!status.ok()) { : RETURN_JSON_ERROR_FROM_STATUS(jw, status, resp->status_code); : } > nit for here and elsewhere: consider introducing a macro similar to RETURN_ Done -- To view, visit http://gerrit.cloudera.org:8080/22744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cdb14d5a932eb8d1ba209ca803731749117024e Gerrit-Change-Number: 22744 Gerrit-PatchSet: 6 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 23 Apr 2025 14:56:52 +0000 Gerrit-HasComments: Yes
