Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22806 )

Change subject: [RANGER] KUDU-3661 Ranger policy not honored in Kudu
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22806/2//COMMIT_MSG@7
PS2, Line 7: [RANGER]
nit: drop this since JIRA ID should be enough already?


http://gerrit.cloudera.org:8080/#/c/22806/2/src/kudu/master/ranger_authz_provider.cc
File src/kudu/master/ranger_authz_provider.cc:

http://gerrit.cloudera.org:8080/#/c/22806/2/src/kudu/master/ranger_authz_provider.cc@286
PS2, Line 286: unordered_set
BTW, using unordered_set here isn't a good idea from performance perspective.  
It's trivial thing to fix, but that should be handled in a separate changelist, 
of course.

Probably, we could take care of that after 1.18.0 is released.



--
To view, visit http://gerrit.cloudera.org:8080/22806
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I635132154d622eb41e993a0a1a818b21b5af6bb7
Gerrit-Change-Number: 22806
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Wed, 23 Apr 2025 20:50:16 +0000
Gerrit-HasComments: Yes

Reply via email to