Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22805 )
Change subject: [common] ColumnPredicate clean-up
......................................................................
[common] ColumnPredicate clean-up
Since I'm planning to update the code in common/column_predicate.cc
in follow-up changelists, in this separate patch I cleaned up
the code a bit:
* use 'if constexpr' where possible for cleaner code
* clean up CHECK/DCHECK assertions
* make it C++ style guide-compliant
* address other minor issues reported by linters
I verified that the new code's benchmark numbers didn't degrade
by running and comparing output of
KUDU_ALLOW_SLOW_TESTS=1 ./bin/column_predicate-test
Specifically, by running NullPredicateBenchmark.TestIsNotNull multiple
times before and after this patch at the same machine, I observed better
numbers in average, with typical numbers like below:
Before:
int32 NOT NULL (c IS NOT NULL) 91937.5M evals/sec 0.03 cycles/eval
int32 NULL (c IS NOT NULL) 93090.9M evals/sec 0.03 cycles/eval
NullPredicateBenchmark.TestIsNotNull (23 ms)
After:
int32 NOT NULL (c IS NOT NULL) 104682.1M evals/sec 0.02 cycles/eval
int32 NULL (c IS NOT NULL) 114375.1M evals/sec 0.02 cycles/eval
NullPredicateBenchmark.TestIsNotNull (20 ms)
This patch doesn't have any functional modifications.
Change-Id: I5d238a86d301b09247d8ed1d7deeb738eb20b11f
Reviewed-on: http://gerrit.cloudera.org:8080/22805
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Yifan Zhang <[email protected]>
---
M src/kudu/common/column_predicate.cc
1 file changed, 103 insertions(+), 104 deletions(-)
Approvals:
Alexey Serbin: Verified
Yifan Zhang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d238a86d301b09247d8ed1d7deeb738eb20b11f
Gerrit-Change-Number: 22805
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
