Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22806 )
Change subject: KUDU-3661 Ranger policy not honored in Kudu ...................................................................... Patch Set 8: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22806/8/src/kudu/integration-tests/ts_authz-itest.cc File src/kudu/integration-tests/ts_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/22806/8/src/kudu/integration-tests/ts_authz-itest.cc@633 PS8, Line 633: for nit: to http://gerrit.cloudera.org:8080/#/c/22806/8/src/kudu/integration-tests/ts_authz-itest.cc@635 PS8, Line 635: cluster_)); nit for this and two other ASSERT_OK() lines below: wrong indent http://gerrit.cloudera.org:8080/#/c/22806/8/src/kudu/integration-tests/ts_authz-itest.cc@641 PS8, Line 641: // Perform INSERT and UPDATE operations on the table. Nit for this and other comments in this new test scenario: these don't have much value since they are just re-stating what's quite clear from the code itself. Meaningful comments tend to explain the reason behind a particular action, answering to 'why?' rather than 'what?' question (but the latter also happens if there is something non-obvious going on behind the scene). If you are up to adding a few comments, please shed some light on the following: * Why to have SELECT privilege granted to the user while not a single read/scan is performed? * What part of the scenario fails if KUDU-3661 fix is absent? -- To view, visit http://gerrit.cloudera.org:8080/22806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I635132154d622eb41e993a0a1a818b21b5af6bb7 Gerrit-Change-Number: 22806 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 24 Apr 2025 18:27:26 +0000 Gerrit-HasComments: Yes
