Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22810 )
Change subject: [webserver] Add 403 Forbidden HTTP status code ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22810/1/src/kudu/master/rest_catalog_path_handlers.cc File src/kudu/master/rest_catalog_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/22810/1/src/kudu/master/rest_catalog_path_handlers.cc@92 PS1, Line 92: if (status.IsNotAuthorized()) { nit: I think its worth to add Alexey's reasoning in a small comment, just for future reference. Something like this: // After SPNEGO authentication, the server assumes the caller is known and authenticated. // A NotAuthorized status at this point indicates the user is authenticated but lacks permission, // which semantically maps better to HTTP 403 Forbidden than 401 Unauthorized. // See: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status#client_error_responses Feel free to adjust it as you feel appropriate. -- To view, visit http://gerrit.cloudera.org:8080/22810 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e1b89c7a673b7de0567958ba23beb57d7f2db Gerrit-Change-Number: 22810 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 25 Apr 2025 10:10:33 +0000 Gerrit-HasComments: Yes
