Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/22768/10//COMMIT_MSG Commit Message: PS10: I downloaded the patch, applied it on top of the main branch, and ran `./gradlew clean -Dmaven.repo.local=<localRepoPath> publishToMavenLocal` from the $KUDU_HOME directory. I took a look at the generated kudu-client-1.18.0-SNAPSHOT.pom file. It contains the following: <dependencies> <dependency> <groupId>org.apache.kudu</groupId> <artifactId>kudu-proto</artifactId> <version>1.18.0-SNAPSHOT</version> <scope>runtime</scope> <exclusions> <exclusion> <groupId>com.google.errorprone</groupId> <artifactId>error_prone_annotations</artifactId> </exclusion> <exclusion> <groupId>com.google.j2objc</groupId> <artifactId>j2objc-annotations</artifactId> </exclusion> <exclusion> <groupId>org.checkerframework</groupId> <artifactId>checker-compat-qual</artifactId> </exclusion> <exclusion> <groupId>org.codehaus.mojo</groupId> <artifactId>animal-sniffer-annotations</artifactId> </exclusion> </exclusions> </dependency> ... <dependencies> Since we are not publishing kudu-proto artifact, how is the dependency resolution is supposed to work for a Kudu client Java application that uses kudu-client? The generated POM file states that kudu-client needs kudu-proto in runtime, so how is the application built outside of $KUDU_HOME is going to run? I'm not sure I understand this, but I might be missing some crucial details here. Could you shed some light on this, please? Thank you! -- To view, visit http://gerrit.cloudera.org:8080/22768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0 Gerrit-Change-Number: 22768 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 25 Apr 2025 18:41:27 +0000 Gerrit-HasComments: Yes
