Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22884 )
Change subject: [util] optimise RLE a bit ...................................................................... [util] optimise RLE a bit Since the number of bits for an RLE encoder/decoder doesn't change and is known beforehand, it makes sense to make it a template parameter, allowing the compiler to use compile-time optimisations when possible. There are just a few pre-defined numbers of bits used for RLE encoding/decoding in the production code, so there isn't a risk of code bloat. Change-Id: I0951b7efc8f4a11ec89ccc0dda1be3faf4cc023c Reviewed-on: http://gerrit.cloudera.org:8080/22884 Reviewed-by: Zoltan Martonka <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Marton Greber <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/benchmarks/rle.cc M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_reader.h M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/rle_block.h M src/kudu/util/bit-util.h M src/kudu/util/rle-encoding.h M src/kudu/util/rle-test.cc 8 files changed, 234 insertions(+), 179 deletions(-) Approvals: Zoltan Martonka: Looks good to me, but someone else must approve Marton Greber: Looks good to me, approved; Verified Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/22884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0951b7efc8f4a11ec89ccc0dda1be3faf4cc023c Gerrit-Change-Number: 22884 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
