Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22909 )
Change subject: [java] Change dependency configuration ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/22909/1/java/kudu-backup-tools/build.gradle File java/kudu-backup-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/22909/1/java/kudu-backup-tools/build.gradle@35 PS1, Line 35: testImplementation libs.mockitoCore Could you add a comment why this is necessary? As one can see, none of the tests in kudu-backup-tools use mockitio package, so having libs.mockitoCore here looks surprising to a reading without knowing the context of this. Also, maybe add corresponding JIRA issue, so it will be easier to track and maybe remove this artificially added dependency in posterity. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/22909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20ca5dcc21d325d199fa135806dfa17a16e814f6 Gerrit-Change-Number: 22909 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 16 May 2025 19:03:26 +0000 Gerrit-HasComments: Yes
