Hello Marton Greber, Zoltan Martonka, Attila Bukor, Kudu Jenkins, Abhishek
Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22902
to look at the new patch set (#3).
Change subject: KUDU-3662 [2/n] Add job config parsing
......................................................................
KUDU-3662 [2/n] Add job config parsing
This patch introduces a configuration model and CLI parser for job-level
replication settings.
- Introduced ReplicationJobConfig to encapsulate parameters like
source/sink Kudu master addresses, table name, etc.
- Added ReplicationConfigParser with a static parseJobConfig method
for extracting job.* parameters from ParameterTool.
- CLI argument parsing follows a naming convention with job., reader.,
and writer.* prefixes. This patch adds support for job.* only.
- The parsed job config is passed to ReplicationEnvProvider and will be
used in follow-up patches.
- Added unit tests for config parsing in TestReplicationConfigParser.
- Added AssertJ as a test dependency for more expressive assertions.
Note: added a temporary exclusion rule to suppress "URF_UNREAD_FIELD"
SpotBugs error, since the jobConfig field will be used in following
commits, this exclusion should be removed when no longer relevant.
Change-Id: Ic7229e11baa6a03c8986f206f456725acda00774
---
M java/config/spotbugs/excludeFilter.xml
M java/gradle/dependencies.gradle
M java/kudu-replication/build.gradle
A
java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationConfigParser.java
M
java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationEnvProvider.java
M
java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationJob.java
A
java/kudu-replication/src/main/java/org/apache/kudu/replication/ReplicationJobConfig.java
A
java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplicationConfigParser.java
8 files changed, 334 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/22902/3
--
To view, visit http://gerrit.cloudera.org:8080/22902
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic7229e11baa6a03c8986f206f456725acda00774
Gerrit-Change-Number: 22902
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>