Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22882 )
Change subject: [socket] Fix test failure caused due to unsupported socket option ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22882/3/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: http://gerrit.cloudera.org:8080/#/c/22882/3/src/kudu/master/mini_master.cc@61 PS3, Line 61: opts_.rpc_opts.rpc_reuseport = FLAGS_rpc_reuseport; > I don't think that explanation justifies for this change -- it simply doesn If you are just looking for next steps in this context and want to introduce extra level of customization for this MiniMaster's option, please do so in its own changelist. There are multiple benefits for having logically separate updates in the source code repository. In addition to that, if going this or similar route, I'd like to see a bit more holistic approach. There is MiniTabletServer and other components of the Kudu's test scaffolding that use ServerBaseOptions and derived data structures, where RpcServerOptions is an aggregated part. Throwing in such an update in this changelist only for MiniMaster looks a bit off-topic and not consistent enough. I would highly appreciate if could you limit the amount of modifications in this patch, including the bare minimum to fulfill the summary of this patch (i.e. fixing test failure caused due to unsupported socket option): * handle misconfigurations in address family and reuse port options for RPC sockets * consequently, address the errors and failing tests in your environment once the former item is implemented Thank you! -- To view, visit http://gerrit.cloudera.org:8080/22882 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ice00b1c4fd1df78fa84c3dd2a79c968a4a91cc21 Gerrit-Change-Number: 22882 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 28 May 2025 18:38:54 +0000 Gerrit-HasComments: Yes
