Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22768 )
Change subject: [java] KUDU-3657: fix publishing ...................................................................... Patch Set 21: (3 comments) Please re-base this patch on the top of the main branch: gerrit reports on conflicts as of PS21, so even if this patch were ready to go, we wouldn't be able to merge it. http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-backup-tools/build.gradle File java/kudu-backup-tools/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-backup-tools/build.gradle@38 PS21, Line 38: // testCompileOnly project(path: ":kudu-backup-common") nit: remove the commented line? http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle File java/kudu-client/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-client/build.gradle@47 PS21, Line 47: libs.jsr305 It's not related to this changelist, but overall migration off from jsr305 is long overdue. Many other project migrated away from jsr305 annotations, with just a few notable ones: * https://github.com/google/guava/issues/2960 * https://github.com/ben-manes/caffeine/issues/337 It seems CheckerFramework and Jetbrains annotations among the most viable alternatives. Anyway, since many other project moved away from jsr305 a few years ago, we can take a look, analyze that, and find the best alternative for the Kudu project. http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/22768/21/java/kudu-test-utils/build.gradle@60 PS21, Line 60: compileOnlyApi libs.jsr305 : compileOnly libs.yetusAnnotations I was looking at https://docs.gradle.org/current/userguide/java_library_plugin.html while trying to make sense of this. I'm curious why these seemingly similar libraries are of different dependency configurations/types. Does kudu-test-utils use some annotations from jsr305 that consumers of kudu-test-utils need as well, but not so for yetusAnnotations? That seems highly unlikely, so I just wanted to make sure this isn't a typo. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22768 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie045805a68bfcd16325e1e4dbb38653cefe3a4b0 Gerrit-Change-Number: 22768 Gerrit-PatchSet: 21 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 00:05:59 +0000 Gerrit-HasComments: Yes
