Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/22915 )
Change subject: Add code coverage support for Java ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/22915/2/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/22915/2/build-support/jenkins/build-and-test.sh@605 PS2, Line 605: ! ./gradlew $ > Why to set TESTS_FAILED here, but not EXIT_STATUS? Looks a bit strange sin jacocoAggregatedReport will trigger test execution if necessary. Added a comment for this. Added EXIT_STATUS. http://gerrit.cloudera.org:8080/#/c/22915/2/build-support/jenkins/build-and-test.sh@613 PS2, Line 613: FAILURES="$FAILURES"$'Java Jacoco report processing failed\n' > nit: remove the empty line? Done http://gerrit.cloudera.org:8080/#/c/22915/2/build-support/process_jacoco_report.sh File build-support/process_jacoco_report.sh: http://gerrit.cloudera.org:8080/#/c/22915/2/build-support/process_jacoco_report.sh@20 PS2, Line 20: $KUDU > nit: $KUDU_HOME/java Done http://gerrit.cloudera.org:8080/#/c/22915/2/build-support/process_jacoco_report.sh@34 PS2, Line 34: if [ ! -f "$HTML_REPORT" ]; then : echo "HTML report not found at $HTML_REPORT" : exit 1 : fi : : echo "Appending summary to HTML report..." : { : echo "<pre>" : cat "$SUMMARY_FILE" : echo "</pre>" : } >> "$HTML_REPORT" : ec > nit: consider simplifying the 'if/else' flow by doing something similar to Done -- To view, visit http://gerrit.cloudera.org:8080/22915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15816adb14785eade28581f75918f6848457d190 Gerrit-Change-Number: 22915 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 06 Jun 2025 11:25:31 +0000 Gerrit-HasComments: Yes
