Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22988 )
Change subject: [rpc-test] make RpcPendingConnectionsMetric more stable (take 2) ...................................................................... [rpc-test] make RpcPendingConnectionsMetric more stable (take 2) In very rare cases, 10 ms wait time isn't enough to allow for updated data to be read from diag_sock() when there isn't any pending connections. So, use ASSERT_EVENTUALLY() instead to make the RpcPendingConnectionsMetric scenario more robust. This is a follow-up to a5eb21270. Change-Id: Icc78fc67e85b659460ebc993d62578e541eeccbe Reviewed-on: http://gerrit.cloudera.org:8080/22988 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/rpc/rpc-test.cc 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22988 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Icc78fc67e85b659460ebc993d62578e541eeccbe Gerrit-Change-Number: 22988 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
