Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23001 )
Change subject: WIP KUDU-1261 support 1D-arrays in TypeInfo ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23001/2/src/kudu/common/types.h File src/kudu/common/types.h: http://gerrit.cloudera.org:8080/#/c/23001/2/src/kudu/common/types.h@57 PS2, Line 57: one-dimensional > Do we want to leave some wriggle room for future work on multi-dimensional Right, that's hinted at in 'TODO' at lines 59-60. Since type registry is an implementation detail, and we don't export anything from types.h or install the file for C++ client library, we can do so anytime in future. As of now, I don't see anything beyond these two methods that is necessary for data type resolution in the scope of array data type project. Also, if going beyond 1D scalar arrays right now, it would require re-designing the type registry, but I'm not sure I understand all the requirements for the type registry if supporting multi-dimensional arrays at the time of writing. -- To view, visit http://gerrit.cloudera.org:8080/23001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4215a86c1989d5bc37a6980312fa7fc82f136d60 Gerrit-Change-Number: 23001 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 12 Jun 2025 06:24:01 +0000 Gerrit-HasComments: Yes
