Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23033 )

Change subject: Add support for Rocky Linux in build toolchain scripts
......................................................................


Patch Set 3:

(1 comment)

> Patch Set 3:
>
> (1 comment)
>
> Thank you for your feedback. The adaptation work is still ongoing – a 
> successful compilation build doesn't guarantee normal testing. I'm actively 
> working on the related debugging efforts."

I agree. I pointed out the failures to ensure that these failures are not 
related to current change itself. If that is not the case, I am fine with 
resolving these issues in subsequent patches.

http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh
File build-support/enable_devtoolset.sh:

http://gerrit.cloudera.org:8080/#/c/23033/2/build-support/enable_devtoolset.sh@43
PS2, Line 43: # NOTE: Only test on
> Done
I think there is some confusion. I meant would it be possible to run this for 
every rocky version instead of just version 9. For that, you would need to make 
changes at line 120 and 134 by not including '9' in grep search and call  
custom_run_at_rocky for any rocky version?



--
To view, visit http://gerrit.cloudera.org:8080/23033
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d
Gerrit-Change-Number: 23033
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Jun 2025 12:07:03 +0000
Gerrit-HasComments: Yes

Reply via email to