Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23043 )

Change subject: [build] Jenkins jar verification fix
......................................................................


Patch Set 2:

> Patch Set 2:
>
> (1 comment)
>
> Thanks for looking into this issue!
>
> It is interesting that jars are generated by `check` for some modules but not 
> others.
> It looks like its a task dependency configuration issue. For now I think this 
> approach is nice that at least we have an explicit `assemble` before jar 
> verification.
>
> Regarding the scope of this patch:
> IMHO this patch should contain the fix for the lint failure. If we merge this 
> patch, subsequent rebased patches would fail at the lint stage as long as the 
> fix is not merged.

I think we should keep separate this fix and the lint failure fix, but merge 
the lint failure fix first, then this one. I'll post the other fix today.


--
To view, visit http://gerrit.cloudera.org:8080/23043
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9db6f8dd2a1559cb4a3974d762ba330d1fe3bb2
Gerrit-Change-Number: 23043
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Thu, 19 Jun 2025 07:10:01 +0000
Gerrit-HasComments: No

Reply via email to