Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23033 )
Change subject: [Rocky] Add support for Rocky Linux in build toolchain scripts ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG@9 PS6, Line 9: proper C++17 compilation on Rocky Linux I'm not sure I understand why to bring in GC C12 via devtoolset when it's well known that GCC 11 (which is the default system compiler for Rocky Linux 9.5) has full support of the C++17 standard: https://gcc.gnu.org/projects/cxx-status.html#cxx17 In fact, GCC 8 already had all what's necessary to compile C++17 code, at least it works for Kudu quite well on both RHEL and SUSE Linux distros. http://gerrit.cloudera.org:8080/#/c/23033/6//COMMIT_MSG@20 PS6, Line 20: Kudu can be built on Rocky Linux using gcc-toolset-12 : which provides GCC 12.X.X and full C++17 support Kudu can be built even with GCC8/G++8 with C++17 support, and GCC 11 officially has C++17 as default mode: https://gcc.gnu.org/projects/cxx-status.html#cxx17 Why is this fuss around GCC12 then? What does GCC11/G++11 (that comes as standard C/C++ compiler for Rocky Linux 9.5) miss to have full C++17 support? What's missing there to to succssfully compile Kudu? http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/ccache-gcc-toolset-12/cc File build-support/ccache-gcc-toolset-12/cc: http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/ccache-gcc-toolset-12/cc@19 PS6, Line 19: c++ nit: cc http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/23033/6/build-support/enable_devtoolset.sh@130 PS6, Line 130: (rocky) I don't understand why to have 'rocky' in parentheses. I think the following regex is working the same way: 'ID=["]?rocky["]?' -- To view, visit http://gerrit.cloudera.org:8080/23033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb232f6ec4c36369e79b03370b487ae64aac6f3d Gerrit-Change-Number: 23033 Gerrit-PatchSet: 6 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 25 Jun 2025 17:50:59 +0000 Gerrit-HasComments: Yes
