KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/23057 )
Change subject: [compile] Fix compiler warnings about -Wrange-loop-construct ...................................................................... Patch Set 3: (3 comments) Thanks for you reviews. http://gerrit.cloudera.org:8080/#/c/23057/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23057/2//COMMIT_MSG@15 PS2, Line 15: y, even when using a reference as the loop variable, : and triggers compiler warnings. > Nope, I don't think that's true. The temporary object has the loop scope, Done http://gerrit.cloudera.org:8080/#/c/23057/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/23057/2/src/kudu/tools/kudu-tool-test.cc@7819 PS2, Line 7819: > nit here and below: the asterisk should stick to the type per style guide c Done http://gerrit.cloudera.org:8080/#/c/23057/2/src/kudu/tools/kudu-tool-test.cc@9173 PS2, Line 9173: set, and that fs_wal_dir will be se > I'm not a big fun of string copying. Could we get away with using std::str Done -- To view, visit http://gerrit.cloudera.org:8080/23057 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32a9a043e7aade2c2c879472c13cbf2641daa7f3 Gerrit-Change-Number: 23057 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 27 Jun 2025 07:27:52 +0000 Gerrit-HasComments: Yes
