Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23003 )

Change subject: KUDU-3662 [3/n] Setup source and sink and tests
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23003/2/java/kudu-replication/build.gradle
File java/kudu-replication/build.gradle:

http://gerrit.cloudera.org:8080/#/c/23003/2/java/kudu-replication/build.gradle@21
PS2, Line 21:     // todo(zchovan) confirm if any dependencies should be shaded 
to avoid classpath issues
> Is this todo still relevant?
yes, this is still a task to do


http://gerrit.cloudera.org:8080/#/c/23003/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java
File 
java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java:

http://gerrit.cloudera.org:8080/#/c/23003/2/java/kudu-replication/src/test/java/org/apache/kudu/replication/TestReplication.java@45
PS2, Line 45: ,
> nit: 10, 60000
Ack :)



--
To view, visit http://gerrit.cloudera.org:8080/23003
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dd7122933b125b6d4c6dd5dde27a7e8c3f790d4
Gerrit-Change-Number: 23003
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
Gerrit-Comment-Date: Mon, 30 Jun 2025 08:23:03 +0000
Gerrit-HasComments: Yes

Reply via email to