Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23061 )
Change subject: [ARM ]Fix unaligned pointer warning in CBTree ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23061/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23061/2//COMMIT_MSG@9 PS2, Line 9: On ARM-based platforms nit: The warning appears on x86 platforms as well. http://gerrit.cloudera.org:8080/#/c/23061/2//COMMIT_MSG@23 PS2, Line 23: or use memcpy If you are not using it, better to leave it out from here to avoid any confusion. http://gerrit.cloudera.org:8080/#/c/23061/2/src/kudu/tablet/concurrent_btree.h File src/kudu/tablet/concurrent_btree.h: http://gerrit.cloudera.org:8080/#/c/23061/2/src/kudu/tablet/concurrent_btree.h@606 PS2, Line 606: auto* aligned_ptr = reinterpret_cast<Atomic32*>(unaligned_ptr); question: How does this step ensure alignment safety? -- To view, visit http://gerrit.cloudera.org:8080/23061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8e6f7b0d3516409ae99e4c846f839b6868b3deb Gerrit-Change-Number: 23061 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 04 Jul 2025 07:44:59 +0000 Gerrit-HasComments: Yes
