Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/23052 )
Change subject: SPNEGO authentication in ExternalMiniCluster ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23052/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java: http://gerrit.cloudera.org:8080/#/c/23052/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/MiniKuduCluster.java@806 PS5, Line 806: // https://issues.apache.org/jira/browse/KUDU-3673 and may be implemented in the future. can you add a TODO comment here as well? http://gerrit.cloudera.org:8080/#/c/23052/5/src/kudu/mini-cluster/external_mini_cluster.h File src/kudu/mini-cluster/external_mini_cluster.h: http://gerrit.cloudera.org:8080/#/c/23052/5/src/kudu/mini-cluster/external_mini_cluster.h@338 PS5, Line 338: bool enable_rest_api; nit: can you add the default value in the comment? http://gerrit.cloudera.org:8080/#/c/23052/5/src/kudu/mini-cluster/external_mini_cluster.cc File src/kudu/mini-cluster/external_mini_cluster.cc: http://gerrit.cloudera.org:8080/#/c/23052/5/src/kudu/mini-cluster/external_mini_cluster.cc@1508 PS5, Line 1508: point it at the same keytab nit: I think this is a bit misleading as we don't manually point it to the same keytab as explained below - maybe just omit this part? -- To view, visit http://gerrit.cloudera.org:8080/23052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6035bdf7f2f0f08f53485a7a1aa82ed26148cc4 Gerrit-Change-Number: 23052 Gerrit-PatchSet: 5 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 04 Jul 2025 10:39:51 +0000 Gerrit-HasComments: Yes
