Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23121 )
Change subject: KUDU-3662 [4/n] Add reader & writer config parsing ...................................................................... Patch Set 1: Thanks for the patch! My only ask would be to add some negative test cases to TestReplicationConfigParser, e.g. what would happen if a null value or random value was passed for the replicaSelection param? I haven't seen any detailed checks for that in ReplicationConfigParser either, only a null check. -- To view, visit http://gerrit.cloudera.org:8080/23121 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48633a52046c7b5e637786d8e3c72d89946dc3e9 Gerrit-Change-Number: 23121 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 13:15:50 +0000 Gerrit-HasComments: No
