KeDeng has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23148 )
Change subject: [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS ...................................................................... [util] clean up on SCOPED_OPENSSL_NO_PENDING_ERRORS Add 'const' for ScopedCheckNoPendingSSLErrors instances in the SCOPED_OPENSSL_NO_PENDING_ERRORS macro and instantiate those only if DCHECK_IS_ON() since the corresponding constraints are enforced with the DCHECK_EQ() macro. The motivation for this change was seeing warnings in QtCreator IDE on improving const-correctness for ScopedCheckNoPendingSSLErrors instances as part of the SCOPED_OPENSSL_NO_PENDING_ERRORS macro. This changelist doesn't contains any functional modifications. Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4 Reviewed-on: http://gerrit.cloudera.org:8080/23148 Reviewed-by: KeDeng <[email protected]> Tested-by: KeDeng <[email protected]> --- M src/kudu/util/openssl_util.h 1 file changed, 8 insertions(+), 3 deletions(-) Approvals: KeDeng: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23148 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I94a9b6d34b36567b414599fdd10db64c932074d4 Gerrit-Change-Number: 23148 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]>
