Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23157 )
Change subject: [webserver] avoid memory alloc©ing for HTTP status ...................................................................... [webserver] avoid memory alloc©ing for HTTP status There is no need to create an instance of std::string out of a static string literal just to generate formatted HTTP status line: passing 'const char*' to strings::Substitute() is enough. Also, don't crash on unexpected HTTP status codes in RELEASE builds, but log an error and return '500 Internal Server Error' instead, reserving SIGABRT only for DEBUG builds. This changelist doesn't contains any functional modifications. Change-Id: I58d40bc8bf41791e53b5033ee95e981c6957faa1 Reviewed-on: http://gerrit.cloudera.org:8080/23157 Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Gabriella Lotz <[email protected]> --- M src/kudu/server/webserver.cc 1 file changed, 33 insertions(+), 16 deletions(-) Approvals: Marton Greber: Looks good to me, approved; Verified Gabriella Lotz: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/23157 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I58d40bc8bf41791e53b5033ee95e981c6957faa1 Gerrit-Change-Number: 23157 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
