Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21385 )
Change subject: [glog] Fix minidump-test for cold symbols. ...................................................................... [glog] Fix minidump-test for cold symbols. glog 0.6.0 cannot reliably resolve cold symbols. This was only fixed in recent versions: https://github.com/google/glog/issues/869 This might cause ASSERT_DEATH checks to fail in minidump-test. The long- term solution would be to update to a newer version, but 0.7.1 has a serious issue: stacktrace print crashes for long functions. Since leaving cold symbols this way is not really an issue, backporting the fixes just does not seem worth the time. One affected platform is RHEL 9.3 with default g++. Change-Id: I18d88790d09e9763223a767617794332859cbfad Reviewed-on: http://gerrit.cloudera.org:8080/21385 Reviewed-by: Zoltan Chovan <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/util/minidump-test.cc 1 file changed, 10 insertions(+), 3 deletions(-) Approvals: Zoltan Chovan: Looks good to me, but someone else must approve Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21385 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I18d88790d09e9763223a767617794332859cbfad Gerrit-Change-Number: 21385 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
