Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23169 )
Change subject: [version] Bump up the version to 1.18.1-SNAPSHOT for next release ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23169/1//COMMIT_MSG Commit Message: PS1: Please have a separate changelist to jump bump up the version to 1.18.1-SNAPSHOT, and move all the rest of the updates into separate changelist(s). http://gerrit.cloudera.org:8080/#/c/23169/1/java/gradle/publishing.gradle File java/gradle/publishing.gradle: http://gerrit.cloudera.org:8080/#/c/23169/1/java/gradle/publishing.gradle@119 PS1, Line 119: println "Should sign: $shouldSign" Why is this needed? http://gerrit.cloudera.org:8080/#/c/23169/1/src/kudu/util/status.h File src/kudu/util/status.h: http://gerrit.cloudera.org:8080/#/c/23169/1/src/kudu/util/status.h@139 PS1, Line 139: /** : * \def KUDU_ATTR_NODISCARD : * \brief Marks a function’s return value as **not to be discarded**. : * : * Expands to `[[nodiscard]]` (or : * `__attribute__((warn_unused_result))`) so the compiler warns when : * callers ignore the returned `Status`. : */ (1) please follow the Doxygen convention used in src/client/client.h (2) probably, it makes sense to address this in the master branch first, and then cherry-pick into branch-1.18.x -- To view, visit http://gerrit.cloudera.org:8080/23169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.18.x Gerrit-MessageType: comment Gerrit-Change-Id: I373a885c778157e4e7a13583656fe563807ec169 Gerrit-Change-Number: 23169 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Jul 2025 01:09:09 +0000 Gerrit-HasComments: Yes
