Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23179 )
Change subject: [build] Add compare_poms.py for pom validation ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/23179/2/build-support/compare_poms.py File build-support/compare_poms.py: http://gerrit.cloudera.org:8080/#/c/23179/2/build-support/compare_poms.py@34 PS2, Line 34: import xml.etree.Element > Is this used anywhere? nopre, removed http://gerrit.cloudera.org:8080/#/c/23179/2/build-support/compare_poms.py@39 PS2, Line 39: > Here and elsewhere, remove trailing whitespaces. Done http://gerrit.cloudera.org:8080/#/c/23179/2/build-support/compare_poms.py@227 PS2, Line 227: > Is that possible that there are uncommitted files that can be lost during a yeah, if the checkout is not clean, this will fail, and the whole script with it, I'll have to put in some error handling here -- To view, visit http://gerrit.cloudera.org:8080/23179 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie72412a5c3cbe7dafa2ae37633e3aca025e3d2b9 Gerrit-Change-Number: 23179 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 17 Jul 2025 13:21:01 +0000 Gerrit-HasComments: Yes
