Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23182 )
Change subject: CDPD-64590 Add a new metric to count received RPC calls ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23182/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23182/1//COMMIT_MSG@7 PS1, Line 7: CDPD-64590 Please use upstream Apache JIRA items in the upstream Kudu development. http://gerrit.cloudera.org:8080/#/c/23182/1/src/kudu/rpc/service_pool.cc File src/kudu/rpc/service_pool.cc: http://gerrit.cloudera.org:8080/#/c/23182/1/src/kudu/rpc/service_pool.cc@71 PS1, Line 71: METRIC_DEFINE_counter(server, rpcs_call_count, : "RPC Calls received", : kudu::MetricUnit::kRequests, : "Number of RPCs calls received.", I might be missing something, but I don't think this metric is really needed since the total number of accepted RPC calls can already be tracked by the 'total_count' of the 'rpc_incoming_queue_time' server-level histogram metric: https://kudu.apache.org/docs/metrics_reference.html#kudu-master_rpc_incoming_queue_time At least per the description of this changelist, 'rpc_incoming_queue_time.total_count' should be enough for the use-cases mentioned there. http://gerrit.cloudera.org:8080/#/c/23182/1/src/kudu/rpc/service_pool.cc@75 PS1, Line 75: kWarn Even if introducing this metric, its severity level shouldn't be higher than kInfo priority, but I think of kDebug as the right one. -- To view, visit http://gerrit.cloudera.org:8080/23182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ac516568cecfc4496a05463732472cea6c5fa85 Gerrit-Change-Number: 23182 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 17 Jul 2025 17:44:36 +0000 Gerrit-HasComments: Yes
