Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23184 )
Change subject: [util] simplify DiagnosticSocket::SocketStateWildcard ...................................................................... Patch Set 1: (1 comment) Looks good. Just a nit. http://gerrit.cloudera.org:8080/#/c/23184/1/src/kudu/util/net/diagnostic_socket.h File src/kudu/util/net/diagnostic_socket.h: http://gerrit.cloudera.org:8080/#/c/23184/1/src/kudu/util/net/diagnostic_socket.h@46 PS1, Line 46: SS_ESTABLISHED = 1 Is assignment required here? -- To view, visit http://gerrit.cloudera.org:8080/23184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifdfec2c75e997b5f539b849df51d2894afc399c4 Gerrit-Change-Number: 23184 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 18 Jul 2025 06:28:18 +0000 Gerrit-HasComments: Yes
