Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23149 )
Change subject: [webserver] Add support for TLS 1.3 ...................................................................... Patch Set 5: (3 comments) overall looks good, just one typo in the squeasel patch? http://gerrit.cloudera.org:8080/#/c/23149/4/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/23149/4/src/kudu/server/webserver-test.cc@524 PS4, Line 524: TEST_F(Tls13WebserverTest, TestTlsMinVersion) { > I did some manual testing (added this to the commit message now), but unfor Thank you for checking that out. Alright, this sounds good to me -- at least we know it worked for you as expected during manual testing. http://gerrit.cloudera.org:8080/#/c/23149/5/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/23149/5/thirdparty/download-thirdparty.sh@287 PS5, Line 287: "patch -p1 < $TP_DIR/patches/squeasel-tls-min-version.patch" It would be nice to eventually integrate this into https://github.com/cloudera/squeasel http://gerrit.cloudera.org:8080/#/c/23149/5/thirdparty/patches/squeasel-tls-min-version.patch File thirdparty/patches/squeasel-tls-min-version.patch: http://gerrit.cloudera.org:8080/#/c/23149/5/thirdparty/patches/squeasel-tls-min-version.patch@82 PS5, Line 82: + if (ctx->config[SSL_CIPHERSUITES] != NULL) { : + if (SSL_CTX_set_ciphersuites(ctx->ssl_ctx, ctx->config[SSL_CIPHERSUITES]) != 1) { : + cry(fc(ctx), "SSL_CTX_set_ciphersuites: error setting ciphers (%s): %s", : + ctx->config[SSL_CIPHERSUITES], ssl_error()); : + return 0; : + } : + } Is this a duplicate of the lines 75-80 from above? Seems to be a typo? -- To view, visit http://gerrit.cloudera.org:8080/23149 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba21d62e22962c782ff8013d805b31ff058d9245 Gerrit-Change-Number: 23149 Gerrit-PatchSet: 5 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 21 Jul 2025 15:57:05 +0000 Gerrit-HasComments: Yes
