Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23116 )
Change subject: [build] Add support for Rocky in build toolchain scripts ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23116/1/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/23116/1/build-support/enable_devtoolset.sh@86 PS1, Line 86: # If CC/CXX are not set already, set them to system defaults. nit: is this a stray comment? it seems this should be at line 103 http://gerrit.cloudera.org:8080/#/c/23116/1/build-support/enable_devtoolset.sh@97 PS1, Line 97: else : export CC="/usr/bin/gcc" : export CXX="/usr/bin/g++" Should this be removed because of the code at lines lines 105 and 106? -- To view, visit http://gerrit.cloudera.org:8080/23116 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibc7ef3cc6f4db9f8b4824703e73ea2681fde50e6 Gerrit-Change-Number: 23116 Gerrit-PatchSet: 1 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 22 Jul 2025 05:11:21 +0000 Gerrit-HasComments: Yes
