Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22867 )
Change subject: KUDU-3665: Send no-op heartbeat operations batched - PART 1 ...................................................................... Patch Set 10: I changed to a different approach. Instead of just buffering, we now batch the processing as well. This results in much cleaner logic and does not slow down writes. As you can see, the big mess around the discard logic has been eliminated. CPU usage in a standstill cluster is reduced by more than 50%. So far, I’ve only tested this by enabling batching and running all the unit tests. Always running all affected unit tests with and without batching would significantly increase test runtime (nearly all long tests would be run twice). I can either add it to all corresponding tests and make them run only if an environment variable is set (e.g. KUDU_ALLOW_HEARTBEAT_BATCHING_TESTS), or carefully hand-pick a few tests to run with and without the flags. I think a few new unit tests and further testing are required before we can remove the experimental tag. (With batching off, Kudu should behave exactly as before this commit.) -- To view, visit http://gerrit.cloudera.org:8080/22867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie92ba4de5eae00d56cd513cb644dce8fb6e14538 Gerrit-Change-Number: 22867 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 29 Jul 2025 15:51:57 +0000 Gerrit-HasComments: No
