Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/23307 )
Change subject: [maintenance] fix typo and alignment mismatch ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23307/1//COMMIT_MSG@12 PS1, Line 12: This changelist doesn't contain any functional modifications. > Yes, that seems to be a reasonable approach -- document this as a minor bre I agree with Abhishek. Additionally, I think there is little to no chance that users are modifying this flag. The flag is too internal (applicable to maintenance ops i.e. flush or compaction) from the user perspective. On top of that this is an experimental flag. That said, I also agree that even with remote chance, the user may still get impacted with this change. Even though this is fixing any functional issue, I would prefer to have this change in 1.18.1 to ensure correctness and documentation accuracy and that kind of fits into maintenance release criteria as well. Since Abhishek is looking after the release and I am not sure how much effort it would entail, I will let him take the call. I would be fine if we decide to include it in next minor release. http://gerrit.cloudera.org:8080/#/c/23307/1/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/23307/1/src/kudu/tablet/tablet.cc@195 PS1, Line 195: TAG_FLAG(rows_written_per_sec_for_hot_tablets, experimental); > Do you have any concerns with the backward-compatibility of this update? Nothing other than what is covered in https://gerrit.cloudera.org/#/c/23307/1//COMMIT_MSG@12 I would be surprised if users are actively using this flag either manually or via some deployment scripts. -- To view, visit http://gerrit.cloudera.org:8080/23307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I10ade2b989147799164618c38022aee74d5f5fdd Gerrit-Change-Number: 23307 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 20 Aug 2025 07:43:38 +0000 Gerrit-HasComments: Yes
