Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23045 )
Change subject: Add REST API integration tests ...................................................................... Patch Set 11: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/23045/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23045/10//COMMIT_MSG@9 PS10, Line 9: Additions to master_authz-itest.cc > Oh, okay now it makes sense. The test scenarios were selected to demonstrat Thank you for the explanation. OK, if this set of scenarios gives a sense of good coverage for the code in question, I guess that's enough at least now. And it's possible to add more later, if needed. If thinking about other end-to-end integration details, one might think that the REST API in real world scenario should be used with the HTTPS protocol, not plain HTTP. But I guess that's a separate theme, and can be addressed separately, if at all. http://gerrit.cloudera.org:8080/#/c/23045/10/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/23045/10/src/kudu/integration-tests/master_authz-itest.cc@1055 PS10, Line 1055: ::testing::Values(kRanger), > You're right. The parameterization is indeed a legacy remnant from when mul That sounds good to me -- let's keep the parameter as-is for now. -- To view, visit http://gerrit.cloudera.org:8080/23045 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3ff0dfd67cbc2b5ed0454372dd2bcea71e2ba3 Gerrit-Change-Number: 23045 Gerrit-PatchSet: 11 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 25 Aug 2025 14:59:43 +0000 Gerrit-HasComments: Yes
