Ashwani Raina has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23348
Change subject: WIP [compaction] include undo deltas while picking rowsets ...................................................................... WIP [compaction] include undo deltas while picking rowsets As part of compaction improvement effort, this change is focussing on taking into consideration the size of undo deltas while picking rowsets during rowset compaction. I could not find any historical reason to why it was not done before. Maybe there was some analysis done that ended in a conclusion that considering undo deltas may not be right approach when estimating upper bound fractional solution in the knapsack. The size of undo deltas are taken into consideration while deciding whether a new rowset (a potential compaction 'candidate') fits into the budget and is at least denser than least dense candidate in knapsack. The idea is to get the initial feedback on this approach. And run all the basic sanity tests via dist-test framework. >From unit testing side, I am planning to run some targeted tests on huge dataset with considerable size in undo deltas. Additionally, add a few unit tests once there is some consensus on the approach. Note: This is different from rowset compaction batching effort. Change-Id: I351c0ba96a02e6ded5153adf9d981083a8c40592 --- M src/kudu/tablet/compaction_policy-test.cc M src/kudu/tablet/compaction_policy.cc M src/kudu/tablet/diskrowset.cc M src/kudu/tablet/diskrowset.h M src/kudu/tablet/memrowset.h M src/kudu/tablet/mock-rowsets.h M src/kudu/tablet/rowset.cc M src/kudu/tablet/rowset.h M src/kudu/tablet/rowset_info.cc M src/kudu/tablet/rowset_info.h M src/kudu/tablet/tablet.cc 11 files changed, 24 insertions(+), 24 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/23348/1 -- To view, visit http://gerrit.cloudera.org:8080/23348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I351c0ba96a02e6ded5153adf9d981083a8c40592 Gerrit-Change-Number: 23348 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]>
