Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22984 )
Change subject: KUDU-1457 [1/n] add IPv6 support to net utils ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/22984/14/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: http://gerrit.cloudera.org:8080/#/c/22984/14/src/kudu/util/net/sockaddr.cc@90 PS14, Line 90: if (is_initialized() && family() == AF_INET6) { : storage_.in6.sin6_flowinfo = 0; // Flow-label & traffic class : storage_.in6.sin6_scope_id = 0; // Scope identifier : } > Regardless where the source Sockaddr instance was created, to create an ins Not really. I guess "reinterpret_cast<struct sockaddr*>(&addr), &len)" should ensure that invoked constructor does zeroing out. Removed. http://gerrit.cloudera.org:8080/#/c/22984/14/src/kudu/util/net/sockaddr.cc@100 PS14, Line 100: is_initialized() && > > On whether calling this method with 'len == 0' (which is similar to calli As I pointed out above in my previous comment, the intention behind adding this was to cover all bases, excerpt here: ++ Although, ntp-test failed only for object assignment (i.e. lineno 90 above) I added the check here as well to cover all the bases, just in case there arises a need to use this variant also). ++ As you have confirmed now that Sockaddr::Sockaddr(const struct Sockaddr&, socklen_t) shouldn't ever be called with len == 0, is_initialized() can be removed. -- To view, visit http://gerrit.cloudera.org:8080/22984 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c773ffb2ff44b9cd765b546d6724ec5543586f Gerrit-Change-Number: 22984 Gerrit-PatchSet: 14 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Tue, 02 Sep 2025 09:14:46 +0000 Gerrit-HasComments: Yes
