Gabriella Lotz has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23352 )

Change subject: KUDU-2345 Add developer docs for the python client
......................................................................


Patch Set 3:

(4 comments)

> Patch Set 2:
>
> (5 comments)
>
> Thank you for working on this Gabi!
> Overall looks good to me, just a couple notes/nits.

Thank you for the review! Somehow the fifth comment disappeared and can't find 
it, but I added that as well (the debugging comment).

http://gerrit.cloudera.org:8080/#/c/23352/2/python/README.md
File python/README.md:

http://gerrit.cloudera.org:8080/#/c/23352/2/python/README.md@22
PS2, Line 22:
> I just noticed that on some installations we might need to manually run OS
Done


http://gerrit.cloudera.org:8080/#/c/23352/2/python/README.md@24
PS2, Line 24:
> maybe its advantageous to add a link to virtualenv website if someone does
Done


http://gerrit.cloudera.org:8080/#/c/23352/2/python/README.md@71
PS2, Line 71:
> nit: its a bit nicer since you already define KUDU_HOME above ->
Done


http://gerrit.cloudera.org:8080/#/c/23352/2/python/README.md@74
PS2, Line 74: ```bash
> nit: i've just checked the after build_ext i would like to run a single uni
Done



--
To view, visit http://gerrit.cloudera.org:8080/23352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd38ecd5acf4a40c7f04d89c073d093ac5c83e0
Gerrit-Change-Number: 23352
Gerrit-PatchSet: 3
Gerrit-Owner: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Gabriella Lotz <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Comment-Date: Mon, 08 Sep 2025 09:40:36 +0000
Gerrit-HasComments: Yes

Reply via email to