Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/23398 )
Change subject: [client] clear error message on column type attributes
......................................................................
[client] clear error message on column type attributes
This changelist cleans up error status messages issued by the code in
KuduColumnSpec::ToColumnSchema(), for example:
Before:
precision is not valid on a 2 column: key
After:
precision is not applicable to INT32 column: key
I also took the liberty of updating the code to prepare it for follow-up
updates in the context of KUDU-1261.
This changelist doesn't contain any functional modifications.
Change-Id: Ib616af1409e6b2e5010193a42b61209785b37861
Reviewed-on: http://gerrit.cloudera.org:8080/23398
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
---
M python/kudu/tests/test_schema.py
M src/kudu/client/schema.cc
2 files changed, 102 insertions(+), 78 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23398
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib616af1409e6b2e5010193a42b61209785b37861
Gerrit-Change-Number: 23398
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
