Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23021 )
Change subject: KUDU-1457 [3/n] add IPv6 support for diagnostic socket ...................................................................... Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc File src/kudu/util/net/diagnostic_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/23021/1/src/kudu/util/net/diagnostic_socket-test.cc@202 PS1, Line 202: addr_.ipv6_addr().s > I didn't try it. I believe IPv6 tests should fail at the time of bind, in s I think it's OK to add the IPv6 detection logic later in a separate patch, if needed. As of now, most public cloud providers and Unix-flavor OS distributions have IPv6 enabled by default when creating an new instance of runtime environment. As an alternative, we might consider start requiring IPv6 support for Apache Kudu development activities. http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc File src/kudu/util/net/diagnostic_socket-test.cc: http://gerrit.cloudera.org:8080/#/c/23021/4/src/kudu/util/net/diagnostic_socket-test.cc@111 PS4, Line 111: ASSERT_FALSE(memcmp(src_addr.ipv6_addr().sin6_addr.s6_addr, : entry.src_addr, sizeof(entry.src_addr))); : ASSERT_FALSE(memcmp(&in6addr_any, entry.dst_addr, sizeof(entry.dst_addr))); nit for the future: please use ASSERT_EQ(0, ...) in such cases, similar to other matching cases elsewhere in this file involving memcmp() -- To view, visit http://gerrit.cloudera.org:8080/23021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d78e241a8bb794465a613e7c0a11eea8f628849 Gerrit-Change-Number: 23021 Gerrit-PatchSet: 4 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 10 Sep 2025 19:24:14 +0000 Gerrit-HasComments: Yes
