Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )
Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/schema-test.cc File src/kudu/common/schema-test.cc: http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/schema-test.cc@456 PS11, Line 456: ASSERT_TRUE(col0.Equals(col1, ColumnSchema::COMPARE_NAME)); nit: duplicate http://gerrit.cloudera.org:8080/#/c/23002/11/src/kudu/common/wire_protocol-test.cc File src/kudu/common/wire_protocol-test.cc: PS11: Maybe also check how ColumnSchemaBuilderFromPB behaves if array PB exists but has no type set. -- To view, visit http://gerrit.cloudera.org:8080/23002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270 Gerrit-Change-Number: 23002 Gerrit-PatchSet: 11 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Sep 2025 20:43:33 +0000 Gerrit-HasComments: Yes
