Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23427 )
Change subject: KUDU-1261 fix typo in common/serdes/array1d.fbs ...................................................................... KUDU-1261 fix typo in common/serdes/array1d.fbs Flatbuffers 'Binary' should have been an array of UInt8 (i.e. array of byte arrays), not just array of ubyte/uint8. The Corresponding IDL files under benchmarks/serdes updated as well, and a new test scenario working with Binary added into aserdes-test.cc. This is a follow-up to [1]. [1] http://gerrit.cloudera.org:8080/23364 Change-Id: Ibdeaebd0df3e6d16c7c4b9a33db79956d8dd05ee Reviewed-on: http://gerrit.cloudera.org:8080/23427 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/benchmarks/serdes/arrays.fbs M src/kudu/benchmarks/serdes/arrays.proto M src/kudu/benchmarks/serdes/serdes-test.cc M src/kudu/common/serdes/array1d.fbs 4 files changed, 68 insertions(+), 13 deletions(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/23427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibdeaebd0df3e6d16c7c4b9a33db79956d8dd05ee Gerrit-Change-Number: 23427 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
