Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23002 )
Change subject: KUDU-1261 introduce 1D arrays into ColumnSchema ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/23002/9/src/kudu/client/schema.h File src/kudu/client/schema.h: http://gerrit.cloudera.org:8080/#/c/23002/9/src/kudu/client/schema.h@299 PS9, Line 299: const KuduNestedType kind_; : : union Descriptor { : explicit Descriptor(const KuduArrayTypeDescriptor& desc); : ~Descriptor(); : : const KuduArrayTypeDescriptor array; : } descriptor_; I think a better approach here is to use the PIMPL idiom, hiding implementation details for more freedom in updating this in future without bothering about the ABI compatibility. Also, that way the issue with KuduArrayTypeDescriptor's constructor will be automatically resolved as well. -- To view, visit http://gerrit.cloudera.org:8080/23002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9aeff9a78039651bb727ca65af4e071a2c887270 Gerrit-Change-Number: 23002 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 09 Sep 2025 06:56:37 +0000 Gerrit-HasComments: Yes
