Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/23411 )
Change subject: KUDU-1457 [4/n] enable webserver for IPv6 ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/master/mini_master-test.cc File src/kudu/master/mini_master-test.cc: http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/master/mini_master-test.cc@40 PS1, Line 40: WebServerIPMode I see that we have multiple IP mode enums in this patch, can we consolidate them? http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver-test.cc@1151 PS1, Line 1151: break; nit: DCHECK(false); here as well as above? http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver.cc@256 PS1, Line 256: this nit: do we need 'this', would capturing only opts be enough? http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver_options.h File src/kudu/server/webserver_options.h: http://gerrit.cloudera.org:8080/#/c/23411/1/src/kudu/server/webserver_options.h@28 PS1, Line 28: DUAL_STACK // TODO(araina): See if dual stack is even required are there any further implications if dual stack is required? I mean further changes etc? http://gerrit.cloudera.org:8080/#/c/23411/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/23411/1/thirdparty/build-definitions.sh@728 PS1, Line 728: -DUSE_IPV6" does this mean that if we turn this compile time flag, squeasel will support ipv4 and ipv6? (meaning its not exclusive?) -- To view, visit http://gerrit.cloudera.org:8080/23411 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7095561539f427b5c58ada7b480ca549b0ab795e Gerrit-Change-Number: 23411 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 11:41:50 +0000 Gerrit-HasComments: Yes
